Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Backport PR#973 for 1.0.0 #975

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Conversation

Errorific
Copy link
Contributor

Fix for the cli tests failing on windows getting backported to 1.0.0

@@ -134,7 +134,9 @@ public void displayOutput() {
TEST_LOGGER.info("Standard error {}", commandErrorOutput.toString());
}

CommandLine.Model.CommandSpec parseCommand(final String... args) {
protected CommandLine.Model.CommandSpec parseCommand(final InputStream in, final String... args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the InputStream param?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, but something in master does, will limit the change further

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Errorific Errorific merged commit 5c9fb21 into PegaSysEng:1.0.0 Feb 26, 2019
@Errorific Errorific deleted the backport/pr_973 branch February 26, 2019 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants