This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2046] websocket method permissions #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ests/acceptance/dsl/condition/net/ExpectNetVersionPermissionJsonRpcUnauthorizedResponse.java
Outdated
Show resolved
Hide resolved
...rc/test/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/WebSocketServiceLoginTest.java
Outdated
Show resolved
Hide resolved
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| public class AuthenticationUtils { |
There was a problem hiding this comment.
I couldn't find any unit tests for AuthenticationUtils. This will make it harder to change this class in the future as we won't have anything to verify its current behaviour. Do we have unit tests that will assert the behaviour of this class?
...jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/WebSocketService.java
Outdated
Show resolved
Hide resolved
...jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/WebSocketService.java
Outdated
Show resolved
Hide resolved
...ests/acceptance/dsl/condition/net/ExpectNetVersionPermissionJsonRpcUnauthorizedResponse.java
Outdated
Show resolved
Hide resolved
lucassaldanha
approved these changes
Feb 18, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
websocket service now checks JWT auth token
Fixed Issue(s)
NC-2046