This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix state download race condition by creating a TaskQueue API #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR fixes an issue where the
WorldStateDownloadercould complete prematurely. Previously, there was a race condition where we could be checking to see if the queue is empty after the next round of tasks had been dequeued but before the corresponding requests had been sent and accounted for. To fix this issue, the queue api has been modified so that tasks must be marked as completed before they are completely forgotten. This also sets us up to safely resume an existing queue with a little bit more work.