This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Extract creation and init of ProtocolContext into a re-usable class #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
reviewed
Feb 12, 2019
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/storage/DataStores.java
Outdated
Show resolved
Hide resolved
| this.worldStateStorage = worldStateStorage; | ||
| } | ||
|
|
||
| public static <T> DataStores<T> initDataStores( |
There was a problem hiding this comment.
(discussion) Wondering if this should move to ProtocolContext.init - since it seems to just deal with setting up that object?
There was a problem hiding this comment.
Yes, that would work quite nicely now that you've pointed out the existence of WorldStateArchive.getStorage. I swear I went looking for that and it wasn't there yesterday.... :)
There was a problem hiding this comment.
Done, much nicer now - just moving duplicated code into a ProtocolContext.init.
mbaxter
approved these changes
Feb 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Extracts creation of
BlockchainStorage,MutableBlockchain,WorldStateStorage,WorldStateArchiveandProtocolContextinto a reusable factory. Apart from removing duplication from the differentPantheonControllerimplementations, this will give us a single place to hook in data migrations that we anticipate will be required soon.