This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Shuffled log levels #813
Merged
Shuffled log levels #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
Feb 11, 2019
| @@ -193,18 +193,21 @@ public void handleCommitPayload(final Commit commit) { | |||
| @Override | |||
| public void handleRoundChangePayload(final RoundChange message) { | |||
| final ConsensusRoundIdentifier targetRound = message.getRoundIdentifier(); | |||
| LOG.info("Received a RoundChange Payload for {}", targetRound.toString()); | |||
| LOG.trace("Received a RoundChange Payload for {}", targetRound.toString()); | |||
There was a problem hiding this comment.
no need to do toString on targetRound
.../src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftBlockHeightManager.java
Show resolved
Hide resolved
.../src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftBlockHeightManager.java
Show resolved
Hide resolved
.../src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftBlockHeightManager.java
Show resolved
Hide resolved
| @@ -158,8 +158,9 @@ private void handleMessage(final Message message) { | |||
| public void handleNewBlockEvent(final NewChainHead newChainHead) { | |||
| final BlockHeader newBlockHeader = newChainHead.getNewChainHeadHeader(); | |||
| final BlockHeader currentMiningParent = currentHeightManager.getParentBlockHeader(); | |||
| LOG.debug("Handling New Chain head event, chain length = {}", currentMiningParent.getNumber()); | |||
There was a problem hiding this comment.
isn't this the chain height not chain length? elsewhere is logs I think block is just used to infer block number.
There was a problem hiding this comment.
Updated to be chain height.
went with trace - this is a really normal thing to happen, its not even debug in my opinion. |
jframe
approved these changes
Feb 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.