This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Handle timeouts when requesting checkpoint headers correctly #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Feb 1, 2019
| when(blockchain.contains(block(10).getHash())).thenReturn(false); | ||
| checkpointHeaderManager.clearImportedCheckpointHeaders(); | ||
|
|
||
| // The first checkpoint header should always be in the blockchain (just as geneis was present) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good spot. I'll fix that in a follow-up PR since I think it's worth getting its own review.
ajsutton
referenced
this pull request
in shemnon/pantheon
Feb 3, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix a
NullPointerExceptionwhen downloading checkpoint headers times out. Add unit tests aroundCheckpointHeaderManagerto improve coverage.