This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Log milestones at startup and other minor logging improvements #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When pantheon starts up it now logs the milestone blocks that are in use e.g.
Protocol schedule created with milestones: [Frontier: 0, Homestead: 1150000, DaoRecoveryInit: 1920000, DaoRecoveryTransition: 1920001, Homestead: 1920010, TangerineWhistle: 2463000, SpuriousDragon: 2675000, Byzantium: 4370000, ConstantinopleFix: 7280000]Note that milestones which are skipped (have the same block number as a later milestone) are deliberately omitted so it's clear exactly which milestone you get from a given block. So ropsten outputs:
Protocol schedule created with milestones: [TangerineWhistle: 0, SpuriousDragon: 10, Byzantium: 1700000, Constantinople: 4230000, ConstantinopleFix: 4939394]Additionally, fix an error in the "Generated new key" log message where the word key was duplicated and don't print "Pausing mining while behind chain head" unless mining is actually enabled.