This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-2206 Remove-- max-trailing-peers option #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the option by a constant. Removed option test.
NicolasMassart
added
documentation
…s_option' into NC-2206_remove_max_trailing_peers_option
vinistevam
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 29, 2019
fixed NC-2206 remove --max-trailing-peers Replaces the option by a constant. Removes option test. Doc update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Remove --max-trailing-peers and replace it by a constant as the max is adjusted automatically to the max-peers value.
This is a first step, just to remove it from CLI options. A better refactoring will be discussed later but at least the breaking change will be done.
Fixed Issue(s)
fixes NC-2206