This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PRIV] Add Private transaction abstraction #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransaction.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
private-transaction
branch
from
c36141f to
73d712a
Compare
iikirilov
force-pushed
the
private-transaction
branch
2 times, most recently
from
6b0c58a to
e7cb82f
Compare
antonydenyer
added a commit
to antonydenyer/pantheon
that referenced
this pull request
Jan 22, 2019
commit e7cb82f Author: Ivaylo Kirilov <[email protected]> Date: Mon Jan 21 13:26:50 2019 +0000 Fix PrivateTransaction signature calculation commit d453c66 Author: Ivaylo Kirilov <[email protected]> Date: Mon Jan 21 11:55:37 2019 +0000 Fix PrivateTransaction comment - add params for private transaction specific fields commit 71f9c66 Author: Ivaylo Kirilov <[email protected]> Date: Mon Jan 21 11:54:52 2019 +0000 Add PrivateTransaction Test commit 8464303 Author: Ivaylo Kirilov <[email protected]> Date: Mon Jan 21 11:54:22 2019 +0000 Implement PrivateTransaction
- add params for private transaction specific fields
iikirilov
force-pushed
the
private-transaction
branch
from
e7cb82f to
1d43646
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR creates the private transaction abstraction
Fixed Internal Issue(s)
PRIV-12
Reasoning
It was decided to duplicate the
Transactionclass becausePrivateTransactionandTransactionshould never be used in the same code path -> therefore making common interface felt unnaturalFuture refactor can reduce code duplication. My initial proposition is that the static methods can be moved to a
Transactionsutility class. ThenPrivateTransactionandTransactioncan be simple data classes. This would remove the majority of code duplication.