This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Refactor RoundChangeManager creation #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructor of the RoundChangeManager now accepts a RoundChangeMessageValidator rather than creating it from inputs. This removes complexity from this class, pushes creation back to the validator factory, and simplifies the IbftBlockHeightManagerFactory.
jframe
approved these changes
Jan 16, 2019
| @@ -81,20 +77,13 @@ public RoundChangeCertificate createRoundChangeCertificate() { | |||
| @VisibleForTesting | |||
| final Map<ConsensusRoundIdentifier, RoundChangeStatus> roundChangeCache = Maps.newHashMap(); | |||
|
|
|||
| private final int quorumSize; | |||
| private final long quorum; | |||
There was a problem hiding this comment.
Bit odd we are using quorum here and quorumSize elsewhere. Though it probably should be just quorum everywhere.
There was a problem hiding this comment.
yeah agreed - will do a quick round up.
iikirilov
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 24, 2019
Constructor of the RoundChangeManager now accepts a RoundChangeMessageValidator rather than creating it from inputs. This removes complexity from this class, pushes creation back to the validator factory, and simplifies the IbftBlockHeightManagerFactory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor of the RoundChangeManager now accepts a
RoundChangeMessageValidator rather than creating it from inputs.
This removes complexity from this class, pushes creation back to the
validator factory, and simplifies the IbftBlockHeightManagerFactory.