Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Ibft - prevent proposed block being imported twice #576

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Jan 15, 2019

Testing indicated that if quorum-1 commit messages is received prior
to the proposal, the proposed block will be imported twice.
Theoretically this is handled safely by the BlockImporter, however
is clearly an error in the IbftRound code.

This commit updates IbftRound such that the import can only occur
once.

Testing indicated that if quorum-1 commit messages is received prior
to the proposal, the proposed block will be imported twice.
Theoretically this is handled safely by the BlockImporter, however
is clearly an error in the IbftRound code.

This commit updates IbftRound such that the import can only occur
once.
@rain-on rain-on requested review from jframe and CjHare January 15, 2019 22:59
@rain-on rain-on changed the title Prevent the block being mined twice Ibft - prevent proposed block being imported twice Jan 15, 2019
Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rain-on rain-on merged commit 65a4aee into PegaSysEng:master Jan 17, 2019
@rain-on rain-on deleted the import_twice branch January 24, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants