Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[NC-2094] Tests that cli options are disabled under docker #566

Merged
merged 2 commits into from
Jan 16, 2019
Merged

[NC-2094] Tests that cli options are disabled under docker #566

merged 2 commits into from
Jan 16, 2019

Conversation

Errorific
Copy link
Contributor

Test that certain options are disabled under the docker environment variable and that we're using defaults that match our expectations in such an environment.

@Errorific Errorific requested a review from mark-terry January 15, 2019 04:12
mark-terry
mark-terry approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Errorific Errorific merged commit ab45103 into PegaSysEng:master Jan 16, 2019
@Errorific Errorific deleted the feature/NC-2094.tests_for_docker_defaults branch January 16, 2019 01:53
iikirilov pushed a commit to vinistevam/pantheon that referenced this pull request Jan 24, 2019
@Errorific @iikirilov
[NC-2094] Tests that cli options are disabled under docker, and that …
220f87f 
…datadir defaults (PegaSysEng#566)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mark-terry mark-terry mark-terry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Errorific @mark-terry