This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NewRoundMessageValidator ignores Round Number when comparing blocks #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewRoundMessageValidator previously ensured the block in the newest PreparedCertificate was the same as that in the Proposal by comparing block hashes. However, the hash-function for received IBFT blocks includes round number - thus the blocks will never be deemed 'equal'. As such, the blocks must be compared using a hash function which ignores the round number - i.e. the OnChain function.
CjHare
reviewed
Jan 9, 2019
| @@ -289,4 +268,25 @@ public void lastestPreparedCertificateMatchesNewRoundProposalIsSuccessful() { | |||
|
|
|||
| assertThat(validator.validateNewRoundMessage(msg)).isTrue(); | |||
There was a problem hiding this comment.
Based on the name for the this test and the added comments referring to failing validation, should this assertion be a isFalse() rather than isTrue()?
There was a problem hiding this comment.
It looks like this test is proving the successful case when we have multiple PrepareCertificates, so ATM, I think its correct.
There was a problem hiding this comment.
My bad, in GitHub interface I'd assumed choosing to expand the collapsed section fully expanded ...turns out multiple clicks were needed, the isTrue() is in the succeed test, not the fail test.
jframe
reviewed
Jan 9, 2019
.../test/java/tech/pegasys/pantheon/consensus/ibft/validation/NewRoundMessageValidatorTest.java
Show resolved
Hide resolved
jframe
approved these changes
Jan 9, 2019
CjHare
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewRoundMessageValidator previously ensured the block in the newest
PreparedCertificate was the same as that in the Proposal by comparing
block hashes.
However, the hash-function for received IBFT blocks includes round
number - thus the blocks will never be deemed 'equal'.
As such, the blocks must be compared using a hash function which
ignores the round number - i.e. the OnChain function.
PR description
Fixed Issue(s)