This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
ibft controller and future msgs handling #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
approved these changes
Dec 17, 2018
rain-on
reviewed
Dec 17, 2018
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Show resolved
Hide resolved
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Outdated
Show resolved
Hide resolved
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Outdated
Show resolved
Hide resolved
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Outdated
Show resolved
Hide resolved
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Outdated
Show resolved
Hide resolved
…thub.com:jframe/pantheon into feature/ibft_controller_and_future_msgs_handling
…nt height otherwise log and discard
…block height messages
rain-on
reviewed
Dec 17, 2018
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Outdated
Show resolved
Hide resolved
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Show resolved
Hide resolved
…thub.com:jframe/pantheon into feature/ibft_controller_and_future_msgs_handling
rain-on
approved these changes
Dec 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The IBFT controller handler will create a block height managers as needed and pass on message for the current height. For block at a future height it will buffer these until such a time that a new block event is received and then replay the messages.
Fixed Issue(s)