Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Fix pantheon.cli.PantheonCommandTest test on Windows #380

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

Nashatyrev
Copy link
Contributor

@Nashatyrev Nashatyrev commented Dec 7, 2018

  1. change replaceAll to replace since the first one treats backslashes in replacement string as special chars. (surprisingly replace also replaces all occurrences :)
  2. Since we are injecting a path as a TOML sting literal, we need to escape all TOML special symbols. I didn't find suitable function in the TOML lib, but escaping looks almost compatible with Java strings, so I used Java escaping. For this I added Apache commons-text test dependency. If anybody knows suitable existing lib I would happily replace this new dependency

Resolve #379

…bols 2. string literal should be escaped for TOML

Resolve #379
@Errorific Errorific merged commit e0d4f21 into PegaSysEng:master Dec 7, 2018
@Nashatyrev Nashatyrev deleted the fix-test-win branch December 7, 2018 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants