This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
ReworkVoteTallyCache to better represent purpose #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
changed the title
ajsutton
approved these changes
Dec 4, 2018
| voteTallyUpdater.updateForBlock(h, tally); | ||
| voteTallyCache.put(h.getHash(), tally.copy()); | ||
| voteTallyUpdater.updateForBlock(h, mutableVoteTally); | ||
| voteTallyCache.put(h.getHash(), mutableVoteTally.copy()); |
There was a problem hiding this comment.
For the record, this is the key to the bug fix. Previously the VoteTally that was originally retrieved from the cache was modified and then a copy added for the new block, resulting in the original and new both being the vote tally for the new block. Now it copies before modifying so the original value is unchanged.
…urpose VoteTallyCache has been refactored to simplify some logic.
rain-on
force-pushed
the
vtc
branch
2 times, most recently
from
f8673aa to
556b72e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VoteTallyCache has been refactored to simplify some logic.
Resolved issue whereby an existing voteTally could be polluted with votes from the next block.