This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1524] Update get validators for block hash test to start from block 1 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with block number test and wait for first block
…eToGetValidatorsForBlockHash is working
…ests on build servers
…current block height for comparison holds
rain-on
reviewed
Dec 6, 2018
...sts/src/test/java/tech/pegasys/pantheon/tests/acceptance/clique/CliqueGetSignersRpcTest.java
Outdated
Show resolved
Hide resolved
… isn't adding any value and could make test more brittle
…1' of github.com:jframe/pantheon into feature/clique_at_validators_for_block_hash_start_from_1
rain-on
approved these changes
Dec 7, 2018
jframe
deleted the
feature/clique_at_validators_for_block_hash_start_from_1
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This updates the Clique getSigners shouldBeAbleToGetValidatorsForBlockHash test to first wait for block 1 to be mined. This ensures the block numbers are consistent instead of assuming it will start from block 0. Same approach is done in the getValidatorsForBlockNumber test this test was missed unfortunately.
Also increased the block period to 10 as sometimes there are unexpected delays in starting nodes or processing blocks that affect the clique tests more if the block period is too short.
Fixed Issue(s)