This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-1950: Fixing WebSocket error response #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When using JSON-RPC over WebSockets, the client was returning a wrong JSON-RPC 2.0 response object. Now it is returning a proper error response.
In some cases (e.g. invalid request json), it is not possible to get the request id to include in the response. In this cases, we will set the 'id' field to null in the response json. This is valid as per the JSON-RPC 2.0 specification.
(https://www.jsonrpc.org/specification#response_object)
This invalid error response on the WebSockets is causing some issues integrating with Alethio node explorer.
Fixed Issue(s)
fixes NC-1950