This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix NC-1707 pantheon CLI default values infinite loop #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picocli latest release 3.8.0 fixes the issue.
NicolasMassart
requested review from
ekellstrand,
ajsutton and
lucassaldanha
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The issue of infinite loop was due to an incorrect way to iterate over lines to split them to the right length while displaying descriptions with placeholders like ${DEFAULT-VALUE}
Picocli latest release 3.8.0 fixes the issue, so here is the update and default values are back in descriptions.
Waiting for PR #265 to be merged before merging this one as there's probably some conflicts.
Fixed Issue(s)
fixes NC-1707