This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Set disconnect flag immediately when disconnecting a peer #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously was only set after callbacks were invoked.
mbaxter
approved these changes
Jun 3, 2019
iikirilov
pushed a commit
to Puneetha17/pantheon
that referenced
this pull request
Jun 8, 2019
…#1521) Previously was only set after callbacks were invoked, allowing additional messages to be sent while parts of the supporting infrastructure for the peer was being torn down.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Previously the disconnect flag was only set after callbacks were invoked. Those callbacks performed actions like closing the
EthPeerRequestManagerinstances and other clean-up work that should only happen once no more messages are being sent. However, other threads may still send messages during that period and would not getPeerNotConnectedexceptions.Setting the flag earlier avoids this issue.