Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

If nonce is invalid, do not delete during mining #1422

Merged
merged 4 commits into from
May 9, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented May 9, 2019

No description provided.

@rain-on rain-on requested a review from ajsutton May 9, 2019 00:46
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you make CI happy.

assertThat(pendingTransactions.getTransactionByHash(futureTransaction.hash())).isPresent();
assertThat(results.getTransactions().size()).isEqualTo(0);


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Delete these blank lines.

@rain-on rain-on merged commit f7b9aee into PegaSysEng:master May 9, 2019
@rain-on rain-on deleted the nonce_deletion branch May 9, 2019 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants