JsonRpcError decoding to include message #1336
Conversation
There was a problem hiding this comment.
Given the current state of things this does seem like an improvement but it doesn't feel like we're in the right place.
When does Pantheon parse a JsonRpcError from JSON and why would we expect it to have exactly the same message as we would have used? It seems like if we parsed a JsonRpcError we should just return an object with the supplied code and message and the message probably shouldn't mean anything much to us programmatically and just be something to help users understand what the code means.
|
@ajsutton an interesting point, I'm not entirely sure (or can't recall) the use cases where the JSON errors are needed decoding by Pantheon ...but as the code was already there, I really just keenon keeping things logical correct and consistent across the PegaSys products 🙂 |
|
Maybe we should try deleting it and see if any tests fail? :) |
|
👍 I'll experiment with deleting it (different PR maybe 🤔) |
PR description
With JsonRpcErrors now having multiple errors with the same code, the message need to be included when decoding the JSON to correctly map the error. (bug identified in EthSigner, fix ported)
Fixed Issue(s)