Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Create EnodeURL builder #1275

Merged
merged 2 commits into from
Apr 14, 2019

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Apr 12, 2019

PR description

Builds on #1274 . Create an EnodeURL builder to make it easier to pass parameters of various types. Pass in nodeId as a BytesValue where possible.

@mbaxter mbaxter force-pushed the PAN-2560/create-enode-url-builder branch from 67e87af to ae41d5e Compare April 12, 2019 22:35
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mbaxter mbaxter merged commit 2a333d4 into PegaSysEng:master Apr 14, 2019
usmananwar added a commit to usmananwar/pantheon that referenced this pull request Apr 15, 2019
* Normalize EnodeURLs (PegaSysEng#1264)

Only specify discovery port explicitly when the discovery port differs
from the listening port.

* Expose sync mode option (PegaSysEng#1270)

* Expose sync mode option

- remove `hidden` annotation attribute
- enable `syncModeOptionMustBeUsed` test
fix PAN-2525
fixes PAN-2525

* Update PantheonCommandTest.java

* expose fast sync min peers

* Feature/move subclass in pantheon command (PegaSysEng#1272)

* clean PantheonCommand class

- organize imports
- move `RpcApisConverter` and `RpcApisConversionException` to separate files

* spotlessApply

* register converters

* Revert "register converters"

This reverts commit aec4735.

* [PRIV-46] Use labelled timer to differentiate between rocks db metrics (PegaSysEng#1254)

* Use labelled timer to differentiate between metrics of public and private db

* Update the label names

* Keep enode nodeId stored as a BytesValue (PegaSysEng#1274)

* Refactor RocksDBStats (PegaSysEng#1266)

Move RocksDBStats to it's own module.  This also brings metrics to
metrics:core since none of our other module have nested modules but
they have peer modules.

* Create EnodeURL Builder (PegaSysEng#1275)
@usmananwar usmananwar mentioned this pull request Apr 16, 2019
notlesh pushed a commit to notlesh/pantheon that referenced this pull request Apr 24, 2019
notlesh pushed a commit to notlesh/pantheon that referenced this pull request May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants