This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
OR-306: Fix PermTrustOption setup #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
changed the title
macfarla
approved these changes
Aug 6, 2019
| } | ||
| options.setPemTrustOptions(pemTrustOptions); | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: now that it's more than two lines it looks like dupe
There was a problem hiding this comment.
It is using Vertx builders. I don't think we'll get a lot from abstracting it into a separate class atm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding the CA certificates using the wrong Vertx config. We were adding the CA certificates as if they were a "regular" certificate, what was causing the complaint about invalid key.
I've found on the docs the right way to do it: https://vertx.io/docs/vertx-core/dataobjects.html#PemTrustOptions