Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qrep replication should be marked as completed when initialCopyOnly is true #2515

Closed
alon-zeltser-cyera opened this issue Feb 2, 2025 · 2 comments · Fixed by #2532
Closed
Assignees

Comments

@alon-zeltser-cyera
Copy link

In cdc_flow

	        // if initial_copy_only is opted for, we end the flow here.
		if cfg.InitialSnapshotOnly {
			logger.Info("initial snapshot only, ending flow")
			state.CurrentFlowStatus = protos.FlowStatus_STATUS_COMPLETED
			return state, nil

when initial load is completed the status is changed to STATUS_COMPLETED
but in qrep when initial_copy_only is true nowere is the status being marked as complete and there is no way of knowing it's finished

qrep_flow

		if config.InitialCopyOnly {
			q.logger.Info("initial copy completed for peer flow")
			return state, nil
		}
@saisrirampur
Copy link
Contributor

cc @Amogh-Bharadwaj for visibility

@Amogh-Bharadwaj
Copy link
Contributor

Thanks for flagging! Patching this in a PR here: #2532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants