Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AudioOutputSPDIF3 sync to AudioInputSPDIF3 to avoid glitches #446

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Sep 18, 2022

  1. Make AudioOutputSPDIF3 sync to AudioInputSPDIF3 to avoid glitches

    AudioOutputSPDIF3 can use the Teensy audio clock at 44.1kHz, OR, if an AudioInputSPDIF3 object (which derives its clock from the incoming audio stream) is instantiated, it can and must be synchronised to that. This approach allows a glitch-free system using SPDIF I/O only.
    
    The design GUI has been modified to allow this combination to pass conflict checks; a better implementation may be required.
    h4yn0nnym0u5e committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    0697e6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f7f2cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81a7262 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7bbbbbb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    2bb4e53 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Fix S/PDIF Tx clock to follow Rx clock

    Was just passing audio through, which was not what was wanted at all!
    
    This update feeds the Rx clock back through SAI1 MCLK[3], which seems to be the valid way to do it; SAI2 or SAI3 would also work. As yet untested is the concept that this will sync the entire audio system to the S/PDIF Rx clock, so it becomes possible to use the audio shield too. More clock trickery is probably needed...
    h4yn0nnym0u5e committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    25ab85e View commit details
    Browse the repository at this point in the history
  2. Correct internally-clocked S/PDIF output

    Also copy across code which removes need for a dummy I²S object
    h4yn0nnym0u5e committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    5df2c36 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Configuration menu
    Copy the full SHA
    3849eed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af4ea73 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Remove resource clash indicators

    I²S on SAI1 will now work with S/PDIF input as master clock
    h4yn0nnym0u5e committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5c8fe25 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Configuration menu
    Copy the full SHA
    e65310b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2feb851 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    02dbac2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Various tries at getting S/PDIF MCLK master

    ...all unsuccessful
    h4yn0nnym0u5e committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    7e1d128 View commit details
    Browse the repository at this point in the history
  2. Fix issue with BCLK startup

    Add offset to clock used by output_spdif3.cpp, which changes the interference rate
    It looks like it's slipping 1 sample every so often, so if the SPDIF and PLL4 clocks
    are e.g. 77Hz different then clicks occur at 77Hz
    
    But why?!
    h4yn0nnym0u5e committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3de0215 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Tidy up and update Design Tool info

    Note the comment above the assignment of fs in AudioOutputSPDIF3::config_spdif3() (lines 231-236). For some reason the internal (PLL4-derived) clock has an audible effect, even if the system sample rate is supposedly being derived from the S/PDIF input. The effect seems fairly minor, with the occasional missing or extra samples rather than huge glitches, but it's not hi-fi, and I can't figure out the root cause!
    h4yn0nnym0u5e committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    168926e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Updated documentation

    h4yn0nnym0u5e committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d0f30cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    07de5bd View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Configuration menu
    Copy the full SHA
    64ac682 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    8e47bb3 View commit details
    Browse the repository at this point in the history