Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveshaper "more information" link in webui is broken #456

Open
ianloic opened this issue Feb 25, 2023 · 1 comment
Open

Waveshaper "more information" link in webui is broken #456

ianloic opened this issue Feb 25, 2023 · 1 comment

Comments

@ianloic
Copy link

ianloic commented Feb 25, 2023

Description

In the web ui the "more information" link on the AudioEffectWaveshaper points to https://github.com/dxinteractive/TeensyAudioWaveshaper which 404s

Steps To Reproduce Problem

Go to: https://www.pjrc.com/teensy/gui/?info=AudioEffectWaveshaper
Click "more information" on the right

Maybe @dxinteractive took it private or something? There seems to be a fork of some version of it over at https://github.com/joshnishikawa/TeensyAudioWaveshaper but maybe the information therein could be incorporated into the documentation within the audio library itself?

@dxinteractive
Copy link
Contributor

dxinteractive commented Mar 5, 2023

Hey, sorry about this! I deleted the repo some time ago - I didn’t remember that it was linked to from the teensy docs. That fork would be the same as my version as I don’t think I ever updated that code.

Fwiw the waveshaper wasn’t very good as it has no oversampling so you’re very likely to hit problems with aliasing. I’m not sure if anyone else added that in the last 6 years? I would encourage anyone to write a better version. I’m in favour of withdrawing it from the teensy effects library if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants