New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup proposal #94

Open

rotdrop opened this issue Aug 31, 2022 · 0 comments

Contributor

rotdrop commented Aug 31, 2022

Hi,

I have looked through the code and have some code cleanup proposals:

switch to the more modern Application class instead of using the old appinfo/app.php. Convert from legacy appinfo/app.php to Application class. #92
re-enable the CSRF check. Were there reasons for disabling?. Reenable CSRF checks in controller. #93
WIP: modularize the code a bit and try to use less of the internal APIs in favour of public ones. Feature/modularize controller #91

#91 also has a fix for removing black-listed files, NC would otherwise refuse to delete the extracted directory tree.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment