Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search directory] allow customizing the file preview command #156

Merged
merged 4 commits into from
May 7, 2021

Conversation

neersighted
Copy link
Contributor

Based on the current implementation for directories. Seems straightforward
enough to me, but please let me know if I overlooked something.

@PatrickF1
Copy link
Owner

PatrickF1 commented May 7, 2021

🤯
No one has ever submitted a PR and actually updated the readme. Also you were so fast. THANK YOU!
EDIT: OH, AND YOU WROTE TESTS. Ahhh you're the best :)

README.md Outdated Show resolved Hide resolved
@PatrickF1
Copy link
Owner

Btw, totally up to you, but you can commit normally and push. Don't need to amend and force push unless you like to :)
I don't care either way but some people like to see their commit history in their PR. And occasionally it comes in useful for big PRs when we decide on a previously passed-over solution.

@neersighted
Copy link
Contributor Author

I'm generally of the 'polished' patch set school, so I tend to restructure PRs to maintain the most logical dev history + clean application of patches.

@PatrickF1
Copy link
Owner

Ah even better!

@neersighted neersighted force-pushed the config-preview branch 2 times, most recently from 976501b to 08d250b Compare May 7, 2021 05:57
README.md Outdated Show resolved Hide resolved
@PatrickF1 PatrickF1 changed the title [Search files] allow customizing the file preview command [Search directory] allow customizing the file preview command May 7, 2021
@PatrickF1
Copy link
Owner

Great work! I'll clean up a little from here and merge (sorry, I'm quite obsessive with wording). Thank you SO MUCH Bjorn. Collaborating with you in a tight feedback loop has been my pleasure.

@PatrickF1 PatrickF1 merged commit 3285c08 into PatrickF1:main May 7, 2021
@PatrickF1
Copy link
Owner

Btw, now that you have contributed such a major patch, it would mean a lot to me if you could star the repo. Thanks for considering it!

@kidonng
Copy link
Contributor

kidonng commented May 15, 2021

A little bit late, but I'd like to thank both you! This is a really great feature, I can create really powerful preview now.

No one has ever submitted a PR and actually updated the readme.

I admit I'm bad at this, but at lease I did update the README sometime 😀

@PatrickF1
Copy link
Owner

Glad you like the feature. And thank you for linking to your "really powerful preview". I'm going to add it to the cookbook WIki page. Let me know if you have reservations about that and I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants