-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search directory] allow customizing the file preview command #156
Conversation
🤯 |
feb0e56
to
dc12baf
Compare
dc12baf
to
e328cf5
Compare
Btw, totally up to you, but you can commit normally and push. Don't need to amend and force push unless you like to :) |
I'm generally of the 'polished' patch set school, so I tend to restructure PRs to maintain the most logical dev history + clean application of patches. |
Ah even better! |
976501b
to
08d250b
Compare
08d250b
to
ad0f54c
Compare
Great work! I'll clean up a little from here and merge (sorry, I'm quite obsessive with wording). Thank you SO MUCH Bjorn. Collaborating with you in a tight feedback loop has been my pleasure. |
Btw, now that you have contributed such a major patch, it would mean a lot to me if you could star the repo. Thanks for considering it! |
A little bit late, but I'd like to thank both you! This is a really great feature, I can create really powerful preview now.
I admit I'm bad at this, but at lease I did update the README sometime 😀 |
Glad you like the feature. And thank you for linking to your "really powerful preview". I'm going to add it to the cookbook WIki page. Let me know if you have reservations about that and I'll remove it. |
Based on the current implementation for directories. Seems straightforward
enough to me, but please let me know if I overlooked something.