fzf results contain bind commands #183

037g · 2021-07-03T04:35:47Z

Describe the bug

adding fzf_configure_bindings --directory=\cf to config.fish adds additional lines of text to all fzf results:

bind --preset \\cv fish_clipboard_paste
bind --preset -M insert \\cv fish_clipboard_paste

Steps to Reproduce

Screenshots

Environment

[x ] I have made sure my CLIs meet the minimum version requirements

Versions installed:

Fish: [e.g. 3.2.2] Fish Shell 3.3.0
fzf.fish: [e.g. 7.0] check
plugin manager: [e.g. fisher 4.3.0] check
terminal: [e.g. iTerm] ITerm 3.48
OS: [e.g. macOS 10.15.7] macOS BigSur 11.4

Additional context

Anything else?

The text was updated successfully, but these errors were encountered:

PatrickF1 · 2021-07-03T06:52:22Z

Hmm that is very mysterious indeed. I double checked the code for fzf_configure_bindings and don't see any place where such output would escape.

Does that output also show up when you first start a new fish shell?
can you append 2>/dev/null to your invocation of fzf_configure_bindings in config.fish and see if it still happens?
can you give me the output of bind --user please? (and also double check that they are what you expect)

kidonng · 2021-07-03T16:28:13Z

These lines only appear in __fish_shared_key_bindings. Try remove fish_vi_key_bindings from your Fish config and see if the results are different.

Also, are you using tide?

syphar · 2021-07-05T09:26:05Z

I also started seeing this message after some upgrades, fish and this plugin is up-to-date.

To answer some of the questions:

can you append 2>/dev/null to your invocation of fzf_configure_bindings in config.fish and see if it still happens?

the output when starting the shell still appears.

These lines only appear in __fish_shared_key_bindings. Try remove fish_vi_key_bindings from your Fish config and see if the results are different.

now I'm seeing:

bind: No binding found for sequence '\cv'
bind: No binding found for sequence '\cv'
bind: No binding found for sequence '\cv'
bind: No binding found for sequence '\cv'

can you give me the output of bind --user please? (and also double check that they are what you expect)

here is my output (with some custom bindings):

bind -M insert \cp vv
bind -M insert \ct ftags
bind -M insert \ce insert_heroku_app
bind -M insert \co cdp
bind -M insert \cq fg_
bind -M insert \cc kill-whole-line repaint
bind \cf _fzf_search_directory
bind \e\cl _fzf_search_git_log
bind \e\cs _fzf_search_git_status
bind \cr _fzf_search_history
bind \cv '_fzf_search_variables (set --show | psub) (set --names | psub)'
bind -M insert \cf _fzf_search_directory
bind -M insert \e\cl _fzf_search_git_log
bind -M insert \e\cs _fzf_search_git_status
bind -M insert \cr _fzf_search_history
bind -M insert \cv '_fzf_search_variables (set --show | psub) (set --names | psub)'

Seeing this, could this be a conflict between fzf_configure_bindings and fish_vi_key_bindings both trying to bind \cv?

kidonng · 2021-07-05T09:47:33Z

Try running set -U fish_key_bindings fish_vi_key_bindings once instead of executing fish_vi_key_bindings in your config.fish.

syphar · 2021-07-05T10:21:24Z

Try running set -U fish_key_bindings fish_vi_key_bindings once instead of executing fish_vi_key_bindings in your config.fish.

Then I'm seeing bind: No binding found for sequence '\cv', except when I also remove fzf_configure_bindings --directory=\cf.

kidonng · 2021-07-05T10:25:28Z

At you using tide or anything that runs in background?

Put status -i || exit before your key bindings and try again.

syphar · 2021-07-05T10:49:23Z

At you using tide or anything that runs in background?

yep, tide

Put status -i || exit before your key bindings and try again.

no error then. Interesting is that I still have my mappings.

037g · 2021-07-05T17:08:39Z

I see a pull request to fix this. Thank you.

I am not using tide. Just starship.rs.

@PatrickF1

Does that output also show up when you first start a new fish shell? no, only when some command calls the interactive tool
can you append 2>/dev/null to your invocation of fzf_configure_bindings in config.fish and see if it still happens?
Did not make a difference
can you give me the output of bind --user please? (and also double check that they are what you expect)

Output of:

❯ bind --user
bind -M insert '(' _pisces_insert_left\ \\\(\ \\\)
bind -M insert ')' _pisces_insert_right\ \\\)
bind -M insert '[' _pisces_insert_left\ \\\[\ \\\]
bind -M insert ']' _pisces_insert_right\ \\\]
bind -M insert '{' _pisces_insert_left\ \\\{\ \\\}
bind -M insert '}' _pisces_insert_right\ \\\}
bind -M insert '"' _pisces_insert_identical\ \\\"
bind -M insert \' _pisces_insert_identical\ \\\'
bind -M insert -k backspace _pisces_backspace
bind -M insert \x7f _pisces_backspace
bind -M insert \t _pisces_complete
bind -M insert . _puffer_fish_expand_dots
bind -M insert ! _puffer_fish_expand_bang
bind \cf _fzf_search_directory
bind \e\cl _fzf_search_git_log
bind \e\cs _fzf_search_git_status
bind \cr _fzf_search_history
bind \cv '_fzf_search_variables (set --show | psub) (set --names | psub)'
bind -M insert \cf _fzf_search_directory
bind -M insert \e\cl _fzf_search_git_log
bind -M insert \e\cs _fzf_search_git_status
bind -M insert \cr _fzf_search_history
bind -M insert \cv '_fzf_search_variables (set --show | psub) (set --names | psub)'

Other fish shell plugins.

omf l
Plugins
aws		fish-spec	omf

fisher list
jorgebucaran/fisher
edc/bass
laughedelic/pisces
jethrokuan/z
evanlucas/fish-kubectl-completions
markcial/upto
nickeb96/puffer-fish
h-matsuo/fish-color-scheme-switcher
PatrickF1/fzf.fish
patrickf1/colored_man_pages.fish

037g · 2021-07-05T17:09:49Z

These lines only appear in __fish_shared_key_bindings. Try remove fish_vi_key_bindings from your Fish config and see if the results are different.

Also, are you using tide?

Removing vi bindings fixes the problem.

Kabouik · 2021-07-11T11:47:42Z

I'm observing the same with no bindings set in my Fish config:

# Remove greeting
set fish_greeting

# fzf.fish keybindings (https://github.com/PatrickF1/fzf.fish)
set fzf_fd_opts --hidden --exclude=.git
fzf_configure_bindings --directory=\cF --git_status=\cS --git_log=\cG --history=\cR --variables=\cV

(Excuse the dpi, it's from a 5.9" phone.)

~~However, I'm not using Fish >3.2.0 yet because the package on Debian Sid currently is 3.1.3 only, don't know if this specific problem is related.~~
I am using Fish 3.3.1.

I'm realizing as I post this message that the config to show hidden directories/files with <c-f> doesn't work, but this is probably not related.

kidonng · 2021-07-11T23:55:44Z

@Kabouik maybe use lowercase i.e. \cf instead of \cF.

Kabouik · 2021-07-12T07:52:57Z

That was actually what I did initially, and just tried with upper case later when I saw the issue. It seemed to make no difference unfortunately. It's fairly minor anyway, but just wanted to mention that the issue shows up for me too even though I did not set vi keybindings in my fish config.

…

On 2021-07-12 01:55 Kid ***@***.***> wrote: @Kabouik maybe use lowercase i.e. `\cf` instead of `\cF`. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #183 (comment) 6

PatrickF1 · 2021-07-17T19:59:22Z

Hi @Kabouik! Sorry for the late reply. Can you try adding > /dev/null 2>&1 to your fzf_configure_bindings command and see if it still happens? It'll help me isolate the problem.

PatrickF1 · 2021-07-17T20:40:44Z

Ok actually, you don't need to do that. I thought about it some more and I know what's wrong. It's because you are passing the flag --variables=\cV, which uses $_fzf_search_vars_command. But _fzf_search_vars_command is no longer being set in conf.d/fzf.fish if the shell is interactive. Turns out @kidonng already realized this was a bug a while ago and tried to fix it in #186 but that hasn't been merged yet. Let me merge it and then you can run fisher update

This fixes #183, which is a resulting bug from #180. ## Explanation of the issue #180 makes `$_fzf_search_vars_command` unavailable for non-interactive sessions. However, `fzf_configure_bindings` depends on that variable being available. If the user puts `fzf_configure_bindings` in their `config.fish`, `fzf_configure_bindings` gets executed in non-interactive sessions e.g. fzf preview windows or by tide, and the following line in the function... https://github.com/PatrickF1/fzf.fish/blob/17d54b576919ee77644779db2dcae56d372a8830/functions/fzf_configure_bindings.fish#L33 ...essentially becomes: ```fish test -n $key_sequences[5] && bind --mode $mode $key_sequences[5] ``` which results in error message like `bind --preset \cv fish_clipboard_paste` or `bind: No binding found for sequence '\cv'`. ## Solution Don't execute the entirety of `fzf_configure_bindings` if not in interactive mode. And for good measure, quote `_fzf_search_vars_command` so that even if it does get executed, the bind command will run successfully.

PatrickF1 · 2021-07-17T21:34:59Z

Sorry for everyone who had this issue...now I know why fzf.fish lost 5+ stars in the past 2 weeks :(

Kabouik · 2021-07-18T09:27:16Z

Awesome, that seems to work, thanks @PatrickF1. And fzf.fish is great, no worries, I starred it and started recommending it right after I learnt about it!

…

On 2021-07-17 23:35 Patrick ***@***.***> wrote: Sorry for everyone who had this issue...now I know why fzf.fish lost 5+ stars in the past 2 weeks :( -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #183 (comment) 3

PatrickF1 · 2021-07-18T17:48:35Z

Thanks @Kabouik!

rodrigobdz mentioned this issue Jul 3, 2021

not compatible with fzf.fish rodrigobdz/fish-apple-touchbar#13

Closed

fredericrous mentioned this issue Jul 3, 2021

weird output with fish-apple-touchbar & iterm2 #184

Closed

1 task

kidonng mentioned this issue Jul 5, 2021

Fix bind error messages appearing in non-interactive windows #186

Merged

PatrickF1 closed this as completed in #186 Jul 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fzf results contain bind commands #183

fzf results contain bind commands #183

037g commented Jul 3, 2021

PatrickF1 commented Jul 3, 2021 •

edited

Loading

kidonng commented Jul 3, 2021 •

edited

Loading

syphar commented Jul 5, 2021

kidonng commented Jul 5, 2021

syphar commented Jul 5, 2021

kidonng commented Jul 5, 2021 •

edited

Loading

syphar commented Jul 5, 2021

037g commented Jul 5, 2021

037g commented Jul 5, 2021

Kabouik commented Jul 11, 2021 •

edited

Loading

kidonng commented Jul 11, 2021

Kabouik commented Jul 12, 2021 via email

PatrickF1 commented Jul 17, 2021

PatrickF1 commented Jul 17, 2021 •

edited

Loading

PatrickF1 commented Jul 17, 2021

Kabouik commented Jul 18, 2021 via email

PatrickF1 commented Jul 18, 2021

fzf results contain bind commands #183

fzf results contain bind commands #183

Comments

037g commented Jul 3, 2021

Describe the bug

Steps to Reproduce

Screenshots

Environment

Additional context

PatrickF1 commented Jul 3, 2021 • edited Loading

kidonng commented Jul 3, 2021 • edited Loading

syphar commented Jul 5, 2021

kidonng commented Jul 5, 2021

syphar commented Jul 5, 2021

kidonng commented Jul 5, 2021 • edited Loading

syphar commented Jul 5, 2021

037g commented Jul 5, 2021

037g commented Jul 5, 2021

Kabouik commented Jul 11, 2021 • edited Loading

kidonng commented Jul 11, 2021

Kabouik commented Jul 12, 2021 via email

PatrickF1 commented Jul 17, 2021

PatrickF1 commented Jul 17, 2021 • edited Loading

PatrickF1 commented Jul 17, 2021

Kabouik commented Jul 18, 2021 via email

PatrickF1 commented Jul 18, 2021

PatrickF1 commented Jul 3, 2021 •

edited

Loading

kidonng commented Jul 3, 2021 •

edited

Loading

kidonng commented Jul 5, 2021 •

edited

Loading

Kabouik commented Jul 11, 2021 •

edited

Loading

PatrickF1 commented Jul 17, 2021 •

edited

Loading