add migration message on update

PatrickF1 · May 29, 2021 · a6831e7 · a6831e7
1 parent 1db5203
commit a6831e7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/conf.d/fzf.fish b/conf.d/fzf.fish
@@ -30,3 +30,11 @@ function _fzf_uninstall --on-event fzf_uninstall
     echo "fzf.fish uninstalled"
     set_color normal
 end
+
+function _fzf_migration_message --on-event fzf_update
+    set_color --italics cyan
+    printf '\n%s\n' 'If you last updated fzf.fish before June 2021 and use custom key bindings, you may need to migrate them.'
+    printf '%s\n\n' 'Check out https://github.com/PatrickF1/fzf.fish/wiki/Migration-guides#v70.'
+    set_color normal
+
+end
diff --git a/functions/__fzf_search_shell_variables.fish b/functions/__fzf_search_shell_variables.fish
@@ -4,11 +4,7 @@
 function __fzf_search_shell_variables --argument-names set_show_output set_names_output --description "Search and preview shell variables. Replace the current token with the selected variable."
     # inform users who use custom key bindings of the backwards incompatible change
     if test -z "$set_names_output"
-        set_color red
-        printf '\n%s\n' '__fzf_search_shell_variables now requires arguments so you have to update your key bindings.' >&2
-        printf '%s\n\n' 'Please see github.com/PatrickF1/fzf.fish/releases/tag/v5.0 for the resolution.' >&2
-        set_color normal
-
+        printf '%s\n' '__fzf_search_shell_variables requires 2 arguments.' >&2
         commandline --function repaint
         return 22 # 22 means invalid argument in POSIX
     end