Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: read ReflectionGroups from PG #9801

Merged
merged 3 commits into from
Jun 4, 2024
Merged

chore: read ReflectionGroups from PG #9801

merged 3 commits into from
Jun 4, 2024

Conversation

mattkrick
Copy link
Member

Description

Removes all reads from RethinkDB#RetroReflectionGroup.

Note: this doesn't delete the table! We can't do that until after this has been deployed

@mattkrick mattkrick requested a review from Dschoordsch May 29, 2024 23:00
Dschoordsch
Dschoordsch approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For future reference: this change also includes stopping writes to rethink.

@mattkrick mattkrick merged commit 52b80b5 into master Jun 4, 2024
5 checks passed
@mattkrick mattkrick deleted the chore/retrogroups3 branch June 4, 2024 16:42
@parabol-release-bot parabol-release-bot bot mentioned this pull request Jun 4, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkrick @Dschoordsch