Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update promote team copy #9767

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: update promote team copy #9767

merged 2 commits into from
May 23, 2024

Conversation

nickoferrall
Copy link
Contributor

Fix #9732

Screenshot 2024-05-22 at 14 46 41

To test

  • Go to Teams, and promote a user to the team lead
  • See that the copy takes the following format: Are you sure? User X will be removed as the team leader and User Y will be promoted. User X will no longer be able to change team membership.
  • But it doesn't show the final sentence if the org admin is removing themself as team lead
  • And it says "you" if User X or Y is the viewer

@nickoferrall nickoferrall requested a review from Dschoordsch May 22, 2024 13:53
@nickoferrall nickoferrall merged commit 462a7f4 into master May 23, 2024
5 checks passed
@nickoferrall nickoferrall deleted the fix/9732/change-team-lead-copy branch May 23, 2024 09:53
@parabol-release-bot parabol-release-bot bot mentioned this pull request May 23, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 29, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update language for Org Admins when they're changing the team lead
2 participants
@nickoferrall @Dschoordsch