Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: team lead can view teams in org settings #9739

Merged
merged 4 commits into from
May 22, 2024

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented May 8, 2024

Fix: #9738

image

To test

  • Team lead can view the teams page even if they're not the billing lead

@github-actions github-actions bot added the size/s label May 8, 2024
@nickoferrall nickoferrall requested a review from Dschoordsch May 8, 2024 15:53
@nickoferrall
Copy link
Contributor Author

Updated!

In production, only billing leads can view the Teams page. So a user that is not the billing lead but has been promoted to team lead, can't see the Teams page.

This PR fixes that. But a user could just create a new team in the org, be team lead of that new team, and then have access to the Teams page.

The Teams page contains email information, which is why we restricted it before:

Screenshot 2024-05-09 at 14 37 21

Some options:

  1. Keep things as they are in prod. Only billing leads can see the Teams page.
  2. Use this PR. Team leads can see the Teams page, too. We know that users could join an org, create a new team, and get access to the Teams page.
  3. Use this PR, but in the Teams page, only let team leads who are not the billing lead see the teams that they are the lead of.
  4. Let everyone in the org see the Teams page.

I lean towards options 1 or 3. What do you think?

@nickoferrall nickoferrall requested a review from Dschoordsch May 9, 2024 13:46
@Dschoordsch
Copy link
Contributor

If we would show all teams on that page even when they're not a member, it's like having public teams, just a bit hidden. So I would lean towards 3+4: Everyone can see the team page, but users who are not billing lead or org admin can only see teams they're a member of.
I personally would in that case also like to see a note at the bottom like "There are 35 additional teams you're not a member of" or just "Only showing teams you're a member of", because it's frustrating if you see something different than you're colleague and you don't know why.

@nickoferrall
Copy link
Contributor Author

I like it! Updated 👍

@nickoferrall nickoferrall merged commit 2699c3d into master May 22, 2024
5 checks passed
@nickoferrall nickoferrall deleted the fix/9738/team-lead-view-teams-page branch May 22, 2024 13:40
@github-actions github-actions bot mentioned this pull request May 29, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team lead can't view teams page
2 participants