Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor new meeting team dropdown #9679

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Apr 29, 2024

Description

Fixes #9274
Refactor the meeting select dropdown

Demo

https://www.loom.com/share/036fa7c85f584dd9a49c01ae1c4e2812?sid=9d0ebe45-aa8c-458e-b155-5dbc88b02734

Testing scenarios

  • change team in the AL
  • chose a template with team scope and open the dialog

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Base automatically changed from chore/removeAdHocTeams to master April 29, 2024 13:23
@Dschoordsch Dschoordsch force-pushed the fix/9274/newMeetingTeamPickerRadix branch from f48d877 to f0389d2 Compare May 2, 2024 07:46
@Dschoordsch Dschoordsch marked this pull request as draft May 2, 2024 08:05
@Dschoordsch
Copy link
Contributor Author

There is a use case missing: we had logic to share a team template to the org when the team is switched and the template was scoped to the team. However this wouldn't work when the teams are not on the same org at all and there seems to be no check for this.

@Dschoordsch Dschoordsch requested a review from nickoferrall June 11, 2024 15:46
@Dschoordsch Dschoordsch marked this pull request as ready for review June 11, 2024 15:47
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two menus that need to be changed before merging this are:

  1. The active meetings menu. This is now not taking up enough width:
    Screenshot 2024-06-12 at 09 59 11

  2. When cloning a template, if you click select team, the dropdown menu opens behind the modal:
    Screenshot 2024-06-12 at 09 58 24

@nickoferrall
Copy link
Contributor

I noticed that the first menu is actually an issue in production.

FYI - I've refactored the Menu component slightly in this PR: https://github.com/ParabolInc/parabol/pull/9844/files#diff-e66f67ab51e485a12ee1b7f5726d1dfdc29fb01b119ec1465072350fa4527f84

Moving MenuContent out of Menu meant that we can pass props to MenuContent more easily and adjust how it looks in different places.

@github-actions github-actions bot added size/l and removed size/m labels Jun 25, 2024
@Dschoordsch Dschoordsch requested a review from nickoferrall June 25, 2024 16:25
@Dschoordsch Dschoordsch merged commit 0300ce5 into master Jun 26, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the fix/9274/newMeetingTeamPickerRadix branch June 26, 2024 18:28
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor NewMeetingTeamPicker menu to Radix
2 participants