Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade emoji mart #10463

Merged
merged 5 commits into from
Nov 12, 2024
Merged

chore: upgrade emoji mart #10463

merged 5 commits into from
Nov 12, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Nov 9, 2024

Description

Our TipTap Emoji menu is half broken & the reactji picker doesn't stay on screen in the discussion tab.
To fix it, we first have to upgrade emoji mart, then we can use it to fix everything else...
To fix emoji-mart, we need to use radix-ui/react-popever, which requires #10462

Notes:

  • this uses native emojis, so linux, windows, and apple users will all see slightly different images. this is how it is working currently (tbh I thought i standardized on apple, but i guess not!) this is probably the best way to do it because then we aren't breaking licensing by showing apple emojis on windows devices. It also means we save 4.4MB because we don't have to load the sprite sheet with all the apple emojis.

@github-actions github-actions bot added the size/m label Nov 9, 2024
@mattkrick mattkrick merged commit 1fe8e94 into master Nov 12, 2024
7 checks passed
@mattkrick mattkrick deleted the chore/bump-emoji-mart branch November 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant