Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when starting a checkin with agenda items #10383

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Oct 21, 2024

Description

Resolves #10384
Discussion items were created and inserted before the meeting, which resulted in foreign key errors.

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

  • Create and run through meetings of the following types with and without agenda items on the team:
    • checkin
    • retrospective
    • poker

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch requested a review from mattkrick October 21, 2024 17:08
@Dschoordsch Dschoordsch merged commit 6b817ee into master Oct 21, 2024
9 checks passed
@Dschoordsch Dschoordsch deleted the fix/fixCheckinCrashWithAgendaItems branch October 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQLError: insert or update on table "Discussion" violates foreign key constraint "fk_meetingId"
1 participant