-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Show only available integrations #9908
Conversation
Hide Github, Atlassian and Slack integrations if the oauth environment variables are not set.
LGTM! Just one question: what happens if no integration is available? Shouldn't we show something? I think on the video you say some integrations will always be shown there but I think we should allow to disable those too. |
Also, IMHO this PR would require a full testing round before being released to production. |
I think we should ignore this case. This is only an edge case for private instances. These get support from us in any case, so it's not an issue.
I can add 2 variables to disable Mattermost and MS Teams.
No objection against testing, but it just touches some UI elements, no logic changed. Production should look exactly the same. |
Agreed. I was just curious.
If it's easy and quick, I think you should, but I'll approve the PR without that, as it's not a requirement.
I thought it might risk something other than the UI. In that case, go ahead @Dschoordsch ! |
Description
Fixes #9879
Hide Github, Atlassian and Slack integrations if the oauth environment variables are not set.
If a user has integrated with any of these in the past, then this is not changed. They will be able to use the integration until their token expires. This was already the case before. This PR only affects the visibility of the provider rows.
Demo
https://www.loom.com/share/881a214cb5c042aba2f9df3a96f6f190?sid=658c14b3-8343-4d08-ac48-6cec0b67ed6d 🔒
Testing scenarios
Final checklist