Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Show only available integrations #9908

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Jul 1, 2024

Description

Fixes #9879
Hide Github, Atlassian and Slack integrations if the oauth environment variables are not set.

If a user has integrated with any of these in the past, then this is not changed. They will be able to use the integration until their token expires. This was already the case before. This PR only affects the visibility of the provider rows.

Demo

https://www.loom.com/share/881a214cb5c042aba2f9df3a96f6f190?sid=658c14b3-8343-4d08-ac48-6cec0b67ed6d 🔒

Testing scenarios

  • with the oauth variables for Github, Atlassian and Slack unset check
    • Poker scope
    • Standup Your Work drawer
    • Team integrations
    • Meeting timer
  • repeat with variables set

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Hide Github, Atlassian and Slack integrations if the oauth environment
variables are not set.
@github-actions github-actions bot added the size/s label Jul 1, 2024
@Dschoordsch Dschoordsch marked this pull request as ready for review July 1, 2024 11:00
@rafaelromcar-parabol
Copy link
Contributor

LGTM!

Just one question: what happens if no integration is available? Shouldn't we show something? I think on the video you say some integrations will always be shown there but I think we should allow to disable those too.

@rafaelromcar-parabol
Copy link
Contributor

Also, IMHO this PR would require a full testing round before being released to production.

@Dschoordsch
Copy link
Contributor Author

what happens if no integration is available? Shouldn't we show something?

I think we should ignore this case. This is only an edge case for private instances. These get support from us in any case, so it's not an issue.

some integrations will always be shown there but I think we should allow to disable those too.

I can add 2 variables to disable Mattermost and MS Teams.

Also, IMHO this PR would require a full testing round before being released to production.

No objection against testing, but it just touches some UI elements, no logic changed. Production should look exactly the same.

@Dschoordsch Dschoordsch requested a review from nickoferrall July 1, 2024 14:54
@rafaelromcar-parabol
Copy link
Contributor

I think we should ignore this case.

Agreed. I was just curious.

I can add 2 variables to disable Mattermost and MS Teams.

If it's easy and quick, I think you should, but I'll approve the PR without that, as it's not a requirement.

No objection against testing, but it just touches some UI elements, no logic changed. Production should look exactly the same.

I thought it might risk something other than the UI. In that case, go ahead @Dschoordsch !

@Dschoordsch Dschoordsch merged commit 04bfa6c into master Jul 2, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the chore/9879/showOnlyAvailableIntegrations branch July 2, 2024 12:24
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env var to disable integration providers
2 participants