Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI overlap on mobile meeting start activity screen #9061

Closed
adaniels-parabol opened this issue Oct 26, 2023 · 7 comments · Fixed by #9275
Closed

UI overlap on mobile meeting start activity screen #9061

adaniels-parabol opened this issue Oct 26, 2023 · 7 comments · Fixed by #9275
Assignees
Labels
bug p2 Needs to be addressed on a reasonable timescale

Comments

@adaniels-parabol
Copy link
Contributor

When viewing the meeting start activity screen, there is significant UI overlap causing display and clicking issues.

image

@mwermuth mwermuth added p2 Needs to be addressed on a reasonable timescale Squad - Self Raising labels Nov 7, 2023
@nickoferrall nickoferrall self-assigned this Nov 21, 2023
@nickoferrall
Copy link
Contributor

I think this probably needs to be a design issue unless we have a design already for the mobile view?

Perhaps the sidebar could be narrower and have a white background rather than being see-through? And the user could open and close the sidebar? Although we'd probably always want the "Start Activity" button to be visible.

Another option could be removing the sidebar on mobile. We could show the contents of the sidebar at the top of the page and the template info below it.

What do you think, @acressall?

@nickoferrall nickoferrall removed their assignment Nov 30, 2023
@acressall
Copy link
Contributor

It looks like the mobile view was never built, but @enriquesanchez did design it. Enrique, is this the correct design?

@enriquesanchez
Copy link
Contributor

Hi!

@acressall @nickoferrall Yes, those are the correct designs. I don't know why these were not implemented 😞

@nickoferrall
Copy link
Contributor

Great! Thanks for sharing. I'll remove the design label and work on implementing this 👍

@nickoferrall
Copy link
Contributor

Just wanted to check what you think about this design @enriquesanchez or/and @acressall?

Screenshot 2023-11-30 at 19 00 53

Clicking the downward arrow icon on the right of the settings would minimise the settings, only showing the two CTA buttons (and the button that shows any active meetings).

Then just the settings title with an upward icon would show up, letting the user expand the settings.

My thinking is:

  1. It's simpler to build the above screenshot
  2. When clicking on a settings icon (as in the design below), I expect to be taken to another page, but this would expand the settings.

What I don't like in my suggestion is the downward arrow icon in the Team selection clashes with the icon above it. That's not ideal, but not too bad IMO.

Screenshot 2023-11-30 at 19 05 35

Curious to get your thoughts 🙏

@nickoferrall nickoferrall self-assigned this Nov 30, 2023
@nickoferrall nickoferrall moved this from 📋Todo to 🏗️In Progress in 🧁Product Squad Self Raise Nov 30, 2023
@acressall
Copy link
Contributor

I think the accordion style is more clear, and agree that while the icon misalignment is not ideal, it's not the worst. My one request is to make the settings arrow icon a smidge bigger so it's more tappable. I think the same size as the one below would be ok.

@enriquesanchez
Copy link
Contributor

+1 to Alicia's comments.

@nickoferrall I do want to see how this looks collapsed. We want to avoid users missing the settings and starting an activity on the wrong team :)

@nickoferrall nickoferrall moved this from 🏗️In Progress to 👀Review in 🧁Product Squad Self Raise Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 👀Review to ✅Done in 🧁Product Squad Self Raise Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p2 Needs to be addressed on a reasonable timescale
Projects
Status: Done
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

5 participants