Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make createJiraTaskIntegration/createGitHubTaskIntegration generic #5819

Closed
3 tasks
Dschoordsch opened this issue Dec 21, 2021 · 2 comments · Fixed by #5938
Closed
3 tasks

Make createJiraTaskIntegration/createGitHubTaskIntegration generic #5819

Dschoordsch opened this issue Dec 21, 2021 · 2 comments · Fixed by #5938

Comments

@Dschoordsch
Copy link
Contributor

Both mutations are virtually identical and are just different in the IntegrationManage used. Since we also need a mutation like this for Jira Server and GitLab it is sensible to make it generic first

Acceptance criteria

  • replace createJiraTaskIntegration and createGitHubTaskIntegration with one createTaskIntegration mutation
    • arguments integration of type IntegrationProviderTypeEnum, taskId and projectId
  • all integration specific actions are performed in their respective IntegrationManager
@jordanh jordanh moved this to To Prioritize in Sprint Board Beta Dec 28, 2021
@jordanh jordanh added this to the Jira Server milestone Dec 28, 2021
@jordanh jordanh changed the title Make createJirTaskIntegration/createGitHubTaskIntegration generic Make createJiraTaskIntegration/createGitHubTaskIntegration generic Dec 28, 2021
@jordanh jordanh moved this from To Prioritize to Backlog in Sprint Board Beta Dec 28, 2021
@mattkrick mattkrick moved this from Backlog to Todo in Sprint Board Beta Jan 18, 2022
@igorlesnenko igorlesnenko self-assigned this Jan 19, 2022
@igorlesnenko igorlesnenko moved this from Todo to In Progress in Sprint Board Beta Jan 19, 2022
@Dschoordsch
Copy link
Contributor Author

The idea is to have 2 arguments: taskId is our id, projectId is integration specific and interpreted by the integration manager. For Jira the projectId would be in the format JiraProjectId which already includes the cloudId and projectKey, for GitHub the projectId would be in the format nameWithOwner which is just GitHubs format for a project id.

@igorlesnenko igorlesnenko moved this from In Progress to Reviewer Review in Sprint Board Beta Jan 25, 2022
@Dschoordsch Dschoordsch moved this from Reviewer Review to Self Review in Sprint Board Beta Jan 27, 2022
@igorlesnenko igorlesnenko moved this from Self Review to Reviewer Review in Sprint Board Beta Jan 28, 2022
@elielytz
Copy link

elielytz commented Feb 1, 2022

Testing results

This works like a charm 💯 .

@Dschoordsch Dschoordsch moved this from Reviewer Review to Maintainer Review in Sprint Board Beta Feb 7, 2022
@mattkrick mattkrick moved this from Maintainer Review to Self Review in Sprint Board Beta Feb 7, 2022
@igorlesnenko igorlesnenko moved this from Self Review to Maintainer Review in Sprint Board Beta Feb 8, 2022
@mattkrick mattkrick moved this from Maintainer Review to Done in Sprint Board Beta Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants