Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab Architectural Spec Written #5564

Closed
jordanh opened this issue Oct 22, 2021 · 6 comments
Closed

GitLab Architectural Spec Written #5564

jordanh opened this issue Oct 22, 2021 · 6 comments
Assignees
Labels

Comments

@jordanh
Copy link
Contributor

jordanh commented Oct 22, 2021

Adding support for GitLab is a commonly requested feature and one we're contractually obligated to deliver. We're currently unsure what it would take to implement it. Let's remove this ambiguity.

N.B: @adaniels-parabol can grant the person who takes this issue access to our Gitlab instance

AC

  • Spec written in GitHub with high-level proposal on how implementation proceed, see this as an example
  • After spec reviewed by Review & Maintainer, Epic created and Issues created (including design and implementation issues) and added to Epic
  • Things to consider:

EE

  • 21 hours
@jordanh
Copy link
Contributor Author

jordanh commented Oct 24, 2021

It might be a good idea to design and implement #5567 and #5563 before tackling this completely. This will allow us to create use the patterns we invent for Jira Server to add "GitLab SaaS" and "Gitlab Self-hosted" at the same time

@jordanh jordanh moved this to To Prioritize in Sprint Board Beta Dec 22, 2021
@jordanh jordanh moved this from To Prioritize to Backlog in Sprint Board Beta Dec 23, 2021
@jordanh jordanh removed their assignment Dec 28, 2021
@jordanh jordanh moved this from Backlog to To Prioritize in Sprint Board Beta Feb 4, 2022
@jordanh jordanh moved this from To Prioritize to Backlog in Sprint Board Beta Feb 4, 2022
@jordanh jordanh added the Story Points: 13 Generated by Parabol label Feb 8, 2022
@jordanh
Copy link
Contributor Author

jordanh commented Feb 8, 2022

Include in next sprint?: Y
See the discussion in Planning for Sprint #​​96

Powered by Parabol

@jordanh jordanh moved this from Backlog to Todo in Sprint Board Beta Feb 8, 2022
@nickoferrall
Copy link
Contributor

@jordanh I'd be happy to volunteer for this one

@Dschoordsch
Copy link
Contributor

related: #5968

@mattkrick
Copy link
Member

mattkrick commented Feb 9, 2022

From #5567
There's a good image of how self-hosted should look
foo

We may need an additional dropdown at the bottom for them to select an already-existing self-hosted solution that exists within their org, but aside from that it'd be a good jumping off point

From my 1:1 with Nick, we're gonna punt on the above self-hosted business for now & just get the cloud gitlab working with sprint poker.
Since this AC was written back in October before the big ol gitlab PR was merged we can update the AC to include breaking work into issues.

Proposed updated AC @nickoferrall

  • Create all the issues required to support GitLab in sprint poker (see GitHub or Jira issues for inspiration). Put them in the Sprint Poker GitLab Milestone. Shoot for each issue to be 8 hours or less
  • Include predecessors at the top of each issue description to show what things depend on other things (e.g. creating new gitlab issues likely has a predecessor of Integration task architecture spec'd #5968)
  • Create an overarching issue & put it at the top of the milestone (Georg has a good example, see Jira Server Architectural Spec Written #5563 (comment) for inspiration)
  • Have a final issue that is to spec out building GitLab Self-Hosted

@nickoferrall nickoferrall self-assigned this Feb 10, 2022
@nickoferrall nickoferrall moved this from Todo to In Progress in Sprint Board Beta Feb 10, 2022
@nickoferrall nickoferrall moved this from In Progress to Reviewer Review in Sprint Board Beta Feb 15, 2022
@nickoferrall nickoferrall moved this from Reviewer Review to Maintainer Review in Sprint Board Beta Feb 18, 2022
@mattkrick
Copy link
Member

Closing in favor of #6058

Repository owner moved this from Maintainer Review to Done in Sprint Board Beta Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants