Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize button usage #2232

Closed
ackernaut opened this issue Jun 26, 2018 · 2 comments
Closed

Normalize button usage #2232

ackernaut opened this issue Jun 26, 2018 · 2 comments
Assignees
@ackernaut
Labels
enhancement icebox

Comments

@ackernaut
Copy link
Member

Enhancement

We use button variants. What are the design principles behind the usage? Is this consistent in the app? Also, we have some controls that could be moved to use button variants for consistency, especially in row components in various settings views.

Acceptance Criteria

  • Initial documentation of button usage written
  • Buttons updated to be consistent
  • Funky settings controls moved to use button variants

Estimated effort: 10.5 points (see CONTRIBUTING.md)
@ackernaut ackernaut added this to the Look & Feel milestone Jun 26, 2018
@ackernaut ackernaut self-assigned this Jun 26, 2018
@ackernaut ackernaut mentioned this issue Jun 26, 2018
Merged
30 tasks
@ackernaut
Copy link
Member Author

Still a thing. Scrubbed.

@jordanh jordanh added the icebox label Jul 16, 2019
@jordanh
Copy link
Contributor

jordanh commented Jul 16, 2019

Scrubbed. Iceboxing for now.

@jordanh jordanh closed this as completed Jul 16, 2019
@mattkrick mattkrick mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ackernaut ackernaut

Labels
enhancement icebox
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanh @ackernaut