Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move Comment to TipTap #10576

Merged
merged 11 commits into from
Dec 11, 2024
Merged

feat: move Comment to TipTap #10576

merged 11 commits into from
Dec 11, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Dec 10, 2024 •
edited
Loading

Description

fix #10443

Moves the comments/replies to tiptap

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick changed the title Feat/comments to tiptap feat: move Comment to TipTap Dec 10, 2024
@mattkrick
delete migration
5d4e2fa 
Signed-off-by: Matt Krick <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
removed ThreadedItemReply
3978039 
Signed-off-by: Matt Krick <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick
fix playwright test
9bfbb6e 
Signed-off-by: Matt Krick <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick marked this pull request as ready for review December 11, 2024 22:24
@mattkrick mattkrick merged commit 2fa20b1 into master Dec 11, 2024
7 checks passed
@mattkrick mattkrick deleted the feat/comments-to-tiptap branch December 11, 2024 23:02
@parabol-release-bot parabol-release-bot bot mentioned this pull request Dec 11, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(tiptap): Migrate Comment to TipTap
1 participant
@mattkrick