Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitLab voting to time estimate, weight or label #10549

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Dec 4, 2024

Description

Fixes #6645, #6396
Setting the time estimate could be done just via a quick action which is just a slash command in a comment, but I opted to do the full GraphQL route. Weight is just a variation on it, so did both.

Demo

https://www.loom.com/share/e756c1ea4b434a0f9e4a86f7b04b442b?sid=df61644f-8011-40c1-906e-03277ecc6354

Testing scenarios

  • Sprint Poker with GitLab
  • vote to weight
  • vote to time estimate
  • vote as label

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot added the size/s label Dec 4, 2024
@Dschoordsch Dschoordsch force-pushed the feat/6645/gitlabVoteToEstimate branch from e1d577f to bd95e44 Compare December 4, 2024 12:42
@github-actions github-actions bot added size/m and removed size/s labels Dec 5, 2024
@Dschoordsch Dschoordsch changed the title feat: GitLab voting to time estimate feat: GitLab voting to time estimate, weight or label Dec 5, 2024
Comment on lines +19 to +68
const LabelOptionRoot = styled('div')({
display: 'flex',
justifyContent: 'space-between',
minWidth: '300px'
})

const LabelOptionBlock = styled('div')({
display: 'block',
flexDirection: 'column',
maxWidth: '200px',
paddingTop: 12,
paddingLeft: 16,
paddingBottom: 12,
flexGrow: 1
})

const LabelOptionName = styled('div')({
color: PALETTE.SLATE_700,
display: 'flex',
fontFamily: FONT_FAMILY.SANS_SERIF,
lineHeight: '24px'
})

const LabelOptionSub = styled('div')({
...textOverflow,
color: PALETTE.SLATE_600,
fontFamily: FONT_FAMILY.SANS_SERIF,
fontSize: 12,
lineHeight: '16px'
})

const EditButtonGroup = styled('div')({
paddingLeft: '8px',
paddingRight: '8px',
marginTop: 'auto',
marginBottom: 'auto'
})
const Button = styled(FlatButton)({
alignItems: 'center',
color: PALETTE.SLATE_600,
height: 32,
justifyContent: 'center',
padding: 0,
width: 32
})

const ActionButton = styled(Edit)({
height: 18,
width: 18
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the styled component stuff here, but I just copied it from the GitHubFieldMenu 1:1

@github-actions github-actions bot added size/xl and removed size/m labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

Removed deprecated fields from the schema and then manually removed
empty types resulting from this.
Command to fetch the schema was
```
yarn run get-graphql-schema 'https://gitlab.com/api/graphql?remove_deprecated=true' > packages/server/graphql/nestedSchema/GitLab/gitlabSchema.graphql
```
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@nickoferrall
Copy link
Contributor

nickoferrall commented Dec 9, 2024

Hey @Dschoordsch, GitLab isn't showing up in my integration provider list. I was wondering if there's been any update to the way this works?

Screenshot 2024-12-09 at 13 11 04

@Dschoordsch
Copy link
Contributor Author

You need to have the .env values set correctly (local dev ones are fine) and then run yarn build && yarn predeploy to populate the values into the db.

Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well for me! Code looks good too

@Dschoordsch Dschoordsch merged commit 1cdbf0b into master Dec 9, 2024
7 checks passed
@Dschoordsch Dschoordsch deleted the feat/6645/gitlabVoteToEstimate branch December 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprint Poker: GitLab v2: Push estimate to an issue
2 participants