-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GitLab voting to time estimate, weight or label #10549
Conversation
e1d577f
to
bd95e44
Compare
const LabelOptionRoot = styled('div')({ | ||
display: 'flex', | ||
justifyContent: 'space-between', | ||
minWidth: '300px' | ||
}) | ||
|
||
const LabelOptionBlock = styled('div')({ | ||
display: 'block', | ||
flexDirection: 'column', | ||
maxWidth: '200px', | ||
paddingTop: 12, | ||
paddingLeft: 16, | ||
paddingBottom: 12, | ||
flexGrow: 1 | ||
}) | ||
|
||
const LabelOptionName = styled('div')({ | ||
color: PALETTE.SLATE_700, | ||
display: 'flex', | ||
fontFamily: FONT_FAMILY.SANS_SERIF, | ||
lineHeight: '24px' | ||
}) | ||
|
||
const LabelOptionSub = styled('div')({ | ||
...textOverflow, | ||
color: PALETTE.SLATE_600, | ||
fontFamily: FONT_FAMILY.SANS_SERIF, | ||
fontSize: 12, | ||
lineHeight: '16px' | ||
}) | ||
|
||
const EditButtonGroup = styled('div')({ | ||
paddingLeft: '8px', | ||
paddingRight: '8px', | ||
marginTop: 'auto', | ||
marginBottom: 'auto' | ||
}) | ||
const Button = styled(FlatButton)({ | ||
alignItems: 'center', | ||
color: PALETTE.SLATE_600, | ||
height: 32, | ||
justifyContent: 'center', | ||
padding: 0, | ||
width: 32 | ||
}) | ||
|
||
const ActionButton = styled(Edit)({ | ||
height: 18, | ||
width: 18 | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the styled component stuff here, but I just copied it from the GitHubFieldMenu 1:1
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
Removed deprecated fields from the schema and then manually removed empty types resulting from this. Command to fetch the schema was ``` yarn run get-graphql-schema 'https://gitlab.com/api/graphql?remove_deprecated=true' > packages/server/graphql/nestedSchema/GitLab/gitlabSchema.graphql ```
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size. |
Hey @Dschoordsch, GitLab isn't showing up in my integration provider list. I was wondering if there's been any update to the way this works? |
You need to have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works well for me! Code looks good too
Description
Fixes #6645, #6396
Setting the time estimate could be done just via a quick action which is just a slash command in a comment, but I opted to do the full GraphQL route. Weight is just a variation on it, so did both.
Demo
https://www.loom.com/share/e756c1ea4b434a0f9e4a86f7b04b442b?sid=df61644f-8011-40c1-906e-03277ecc6354
Testing scenarios
Final checklist