Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add yarn pg:build to deployment steps in README #10508

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

svenseeberg
Copy link
Contributor

@svenseeberg svenseeberg commented Nov 21, 2024

Description

When not creating the PostgreSQL migrations, the yarn build command fails.

Fixes #10496

Demo

Freshly clone the repo and run yarn && yarn build. It will fail. When running yarn && yarn pg:build && yarn build the build succeeds.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot requested a review from mattkrick November 21, 2024 09:00
@svenseeberg svenseeberg changed the title Add yarn pg:buidld to deployment steps in README Add yarn pg:build to deployment steps in README Nov 21, 2024
@rafaelromcar-parabol rafaelromcar-parabol changed the title Add yarn pg:build to deployment steps in README fix: Add yarn pg:build to deployment steps in README Nov 25, 2024
@rafaelromcar-parabol
Copy link
Contributor

LGTM.

Could you please verify it @mattkrick? I tested locally and it works, as @svenseeberg says, but I'm not sure if we should include yarn kysely migrate:latest and yarn pg:generate to run the same we run in our build procedure.

  • Doc today: yarn && yarn build
  • @svenseeberg proposal: yarn && yarn pg:build && yarn build
  • Build GH Action: yarn && yarn kysely migrate:latest && yarn pg:build && yarn pg:generate && yarn build (ignoring the --no-deps for the doc).

@mattkrick
Copy link
Member

LGTM! Soon we'll be rid of pg-typed & just use kysely, but until then...

@mattkrick mattkrick merged commit 1c1d17c into ParabolInc:master Nov 26, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants