Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update snyk workflow to use node20 #10324

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

dbumblis-parabol
Copy link
Contributor

@dbumblis-parabol dbumblis-parabol commented Oct 9, 2024

Description

Updates deprecated actions used within workflow to v4 - node20

Demo

N/A

Testing scenarios

Action runs without deprecation warnings

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@dbumblis-parabol dbumblis-parabol changed the title chore: update snyk workfow to use node20 chore: update snyk workflow to use node20 Oct 9, 2024
@dbumblis-parabol dbumblis-parabol added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Oct 9, 2024
@mattkrick mattkrick merged commit 8e1222f into master Oct 9, 2024
15 checks passed
@mattkrick mattkrick deleted the chore/update-snyk-action branch October 9, 2024 17:55
@mattkrick
Copy link
Member

i just merged blindly because I had to do a similar upgrade for another CI test & there's no convenient way to test it other than merging right to master

@github-actions github-actions bot mentioned this pull request Oct 9, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants