Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow using items in unloaded chunks #9727

Conversation

pseudospace0
Copy link

Pretty much the same thing as this:

Subject: [PATCH] Don't allow digging into unloaded chunks
just for ServerboundUseItemOnPacket. There isn't really a need to use up any more time handling the packet if its in an unloaded chunk.

@pseudospace0 pseudospace0 requested a review from a team as a code owner September 15, 2023 15:21
@lynxplay
Copy link
Contributor

Thank you for your third attempt at ensuring unloaded chunks stay untouched!
As with the two previous ones, this one does not look particularly bullet proof.
If you want to contribute to paper, maybe check for some easier PRs first before touching such delicate logic 👍

To potentially save you and us some more time, none of these changes are going to be backported to 1.19 or Folia.
The version is end of life and will at best receive critical bug fixes.

Thank you for your contribution and the good attempts 👍

@lynxplay lynxplay closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants