Provide registered listeners in PluginManager #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
requested changes
Aug 24, 2023
patches/api/0439-Provide-registered-listeners-in-the-PluginManager.patch
Outdated
Show resolved
Hide resolved
patches/api/0439-Provide-registered-listeners-in-the-PluginManager.patch
Outdated
Show resolved
Hide resolved
Aeltumn
force-pushed
the
feat/registered-listeners
branch
from
9b12016
to
38ab827
Compare
Aeltumn
force-pushed
the
feat/registered-listeners
branch
from
38ab827
to
fea8b59
Compare
|
Rebased and ready for re-review. |
powercasgamer
suggested changes
Nov 12, 2023
patches/api/0447-Provide-registered-listeners-in-the-PluginManager.patch
Outdated
Show resolved
Hide resolved
powercasgamer
approved these changes
Nov 15, 2023
patches/api/0447-Provide-registered-listeners-in-the-PluginManager.patch
Outdated
Show resolved
Hide resolved
Aeltumn
force-pushed
the
feat/registered-listeners
branch
from
e01ce03
to
00db803
Compare
Aeltumn
force-pushed
the
feat/registered-listeners
branch
from
b37ebf8
to
0cd87d5
Compare
|
Rebased and cleaned up to match new guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new methods on the PluginManager that supersede the old registerEvent/registerEvents methods. These new methods return a RegisteredListener object which can be used by plugins to better handle their registered listeners. The RegisteredListener now also has an unregister() method which can be used to directly unregister that listener from all relevant handler lists instead of having to iterate over them all.