Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when opening a shipwreck chest containing buried treasure map #7269

Closed
FastJoe0 opened this issue Jan 3, 2022 · 7 comments
Closed

Lag when opening a shipwreck chest containing buried treasure map #7269

FastJoe0 opened this issue Jan 3, 2022 · 7 comments
Labels
resolution: won't fix Issue will not be resolved or feature not added. upstream: vanilla Issue exists in vanilla Minecraft.

Comments

@FastJoe0
Copy link

FastJoe0 commented Jan 3, 2022

Stack trace

https://paste.gg/p/Oamo/e956e78698554d46b2f356889e32140c

Plugin and Datapack List

none

Actions to reproduce (if known)

  1. Type /locate shipwreck
  2. Teleport to the place indicated by the command.
  3. Open the chest in the shipwreck
  4. If the chest has a buried treasure map a big lag will appear.

Paper version

This server is running Paper version git-Paper-132 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 5e30e19)

Other

No response

@FastJoe0 FastJoe0 changed the title Opening a Treasure Chest in wrecked ship causes a huge lag and crash Lag when opening a shipwreck chest containing buried treasure map Jan 4, 2022
@FastJoe0
Copy link
Author

FastJoe0 commented Jan 4, 2022

I have updated actions to reproduce.

@electronicboy
Copy link
Member

This is a vanilla issue in which the search logic for finding features, etc, basically starts running through a huge radius; This is an issue which we've chased consistently back and forth over the years for mojang to 'fix it', breaking our existing patches and such; pregen'ing can help with all the stipulations that induces, but, I'm inclined to believe that this should be replicated on vanilla and sent to them rather than us getting stuck in this consistent cycle of fighting with them over this more or less

@electronicboy electronicboy added resolution: won't fix Issue will not be resolved or feature not added. upstream: vanilla Issue exists in vanilla Minecraft. rejected by team prs welcome and removed status: needs triage labels Jan 4, 2022
@FastJoe0
Copy link
Author

FastJoe0 commented Jan 4, 2022

But it causes the server to crash completely in some cases. Is it possible to somehow block the buried treasure map item so that it doesn't appear in these chests?

@electronicboy
Copy link
Member

electronicboy commented Jan 4, 2022

Yes, you can use a datapack to override the loot for those chests to remove it
We know that it causes issues but we've rewritten the patch for this like 3 times over the past 5 versions, I do not feel that there is much inclination from us to further spend any time wasted on this, it's not a maintainable patch as mojang keeps messing with this

@FastJoe0
Copy link
Author

FastJoe0 commented Jan 4, 2022

Or maybe you will add at least options in paper.yml to disable these maps. If anyone wants, let them use them at their own risk.

Datapacks are not easy to remove from the map in case of problems.

@electronicboy
Copy link
Member

We're not mangling data using config options, use a datapack, there was one floating around and am sure somebody can make one

@ryantheleach
Copy link

ryantheleach commented Feb 12, 2022

@FastJoe0 Datapacks that change loottables should be trivial to remove without side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: won't fix Issue will not be resolved or feature not added. upstream: vanilla Issue exists in vanilla Minecraft.
Projects
None yet
Development

No branches or pull requests

3 participants