Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheep/Bogged/Snowman "regrow wool/mushroom/pumpkin" methods #11638

Closed
NonSwag opened this issue Nov 20, 2024 · 5 comments · Fixed by #11715
Closed

Sheep/Bogged/Snowman "regrow wool/mushroom/pumpkin" methods #11638

NonSwag opened this issue Nov 20, 2024 · 5 comments · Fixed by #11715
Labels
good first issue Simple bug fix or feature which would be a good first PR for someone new to the project scope: api status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.

Comments

@NonSwag
Copy link
Contributor

NonSwag commented Nov 20, 2024

Is your feature request related to a problem?

With the deprecation of the bukkit Shearable API, we lost the ability to force regrow wool or mushrooms for sheep and bogged or "un-derp" snow golems

Describe the solution you'd like.

Methods for those entities to regrow their "features"

Describe alternatives you've considered.

Using the deprecated and marked for removal API from Bukkit

Other

No response

@electronicboy
Copy link
Member

there is already API to derp snow golems; not sure what you mean by 'mushrooms for sheep'

@NonSwag
Copy link
Contributor Author

NonSwag commented Nov 20, 2024

not mushrooms for sheep
"wool and mushrooms" for "sheep and bogged"
sorry for the lack of punctuation

@Machine-Maker
Copy link
Member

Yeah, when upstream made their not-so-great Sheared interface, they moved the setSheared method from Sheep to it, so when we deprecated that new stuff, it left Sheep without a non-depreacted setSheared method. I think we should just re-add both isSheared and setSheared to just Sheep to go back to how it was before they moved it. Should be an easy PR for someone.

@Machine-Maker Machine-Maker added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. good first issue Simple bug fix or feature which would be a good first PR for someone new to the project scope: api and removed status: needs triage labels Nov 24, 2024
@Machine-Maker Machine-Maker moved this to ✅ Accepted in Issues: Bugs Nov 24, 2024
@NonSwag
Copy link
Contributor Author

NonSwag commented Nov 25, 2024

"Good First issue" funny
Just wanted to say that bogged would be left without a non deprecated method if we only re-add setSheared to sheep

@electronicboy
Copy link
Member

Then one should be added to bogged too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple bug fix or feature which would be a good first PR for someone new to the project scope: api status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.
Projects
Status: Done
3 participants